dinbror / bpopup

bPopup is a lightweight jQuery modal popup plugin (only 1.34KB gzipped). It doesn't create or style your popup but provides you with all the logic like centering, modal overlay, events and more. It gives you a lot of opportunities to customize so it will fit your needs.
http://dinbror.dk/bPopup
427 stars 260 forks source link

Pop-up not centered #62

Closed StevenFlecha closed 8 years ago

StevenFlecha commented 8 years ago

Hi,

As various other people I have the problem that the popup is not getting centered. Here is live example: http://rentme.3dprinteroutlet.net/forrent/63/92

Its not properly centered in any of the latest browsers of Chrome, FF, IE.

Bpopup version 0.11

Thanks!

dinbror commented 8 years ago

hey @StevenFlecha .

So it works now after you defined a fixed width?

StevenFlecha commented 8 years ago

Hey, No, its still not centering.

Note it is centering horizontally, just not vertically. It's to far down. In Chrome its still completely in the screen but in FF for example the bottom is cut off because its too far down: http://screencast.com/t/tLtrmJKR

B.r.

dinbror commented 8 years ago

I can see that you have an iframe with a fixed height in the popup, so if you add a fixed height to the sppopcontent container e.g.

.sppopcontent {
height:436px;
} 

then it should work.

StevenFlecha commented 8 years ago

That worked, thanks! Been trying setting fixed heights on various places apparently not that one. Much appreciated.