search

dinedal / textql

Execute SQL against structured text like CSV or TSV
MIT License
9.07k stars 300 forks source link

Use a more-standard and a more common library that is 100% compatible #25

Closed Fale closed 10 years ago

Fale commented 10 years ago

This library is way more common and most distro has already it in their repo.

dinedal commented 10 years ago

I'll have to verify the performance matches up with what I'd expect, but I will consider this change.

dinedal commented 10 years ago

So, in my local tests, loading 1million rows went from 4m26.860928617s to 9m7.046844352s. This implies there is a pretty substantial difference in performance between the bindings, and I'm not sure that there's much that could be done to tweak this new library to perform better.

This library also calls for a hg install instead of just being restricted to git

If you are seeing different performance, I would appreciate more data points, but as it stands I will have to close this PR un-merged. Sorry!