search

dinel / metadiscourse-annotator

0 stars 0 forks source link

[Insight] Object parameters should be type hinted - in src/…/Controller/AdminController.php, line 259 #52

Open dinel opened 6 years ago

dinel commented 6 years ago

in src/AppBundle/Controller/AdminController.php, line 259

The parameter value, which is an object, should be typehinted.


        $sel_vals = $this->getDoctrine()
                    ->getRepository('AppBundle:CharacteristicValuePairs')
                    ->findBy(array('corpus' => $corpus->getId()));

        $selected_vals = array_map(function($value) {
                        return $value->getValue()->getId();
                }, $sel_vals);

        $repository = $this->getDoctrine()

Posted from SensioLabsInsight