dinel / metadiscourse-annotator

0 stars 0 forks source link

[Insight] Object parameters should be type hinted - in src/AppBundle/Utils/SharedFunctions.php, line 100 #61

Closed dinel closed 6 years ago

dinel commented 6 years ago

in src/AppBundle/Utils/SharedFunctions.php, line 100

The parameter em, which is an object, should be typehinted.

     * @param Markable $mark
     * @param type $em
     * @param $doctrine handle to doctrine
     * @param string $form the alternative form to delete
     */
    public static function removeMarkable($mark, $em, $doctrine, $form = null) {
        $tokens = $doctrine->getRepository('\AppBundle\Entity\Token')
                           ->createQueryBuilder('t')
                           ->where('t.markable = :id')
                           ->setParameter('id', $mark->getId())
                           ->getQuery()

Posted from SensioLabsInsight

dinel commented 6 years ago

Closed when fixing #71