dinel / metadiscourse-annotator

0 stars 0 forks source link

[Insight] Object parameters should be type hinted - in src/AppBundle/Utils/SharedFunctions.php, line 145 #62

Closed dinel closed 6 years ago

dinel commented 6 years ago

in src/AppBundle/Utils/SharedFunctions.php, line 145

The parameter mark, which is an object, should be typehinted.

     * Removes a sense
     * @param AppBundle\Entity\Sense $sense
     * @param AppBundle\Entity\Markable $mark
     * @param type $em
     */
    public static function removeSense($sense, $mark, $em, $doctrine) {
        $annotations = $doctrine->getRepository('AppBundle:Annotation')
                                ->createQueryBuilder('a')
                                ->where('a.sense = :id')
                                ->setParameter('id', $sense->getId())
                                ->getQuery()

Posted from SensioLabsInsight