dineug / erd-editor

Entity-Relationship Diagram Editor
https://erd-editor.io
MIT License
874 stars 90 forks source link

Theme: Appearance not respected #372

Closed boris-schwarz closed 3 months ago

boris-schwarz commented 3 months ago

Describe the bug I just installed the ERD Editor Extension and per default the dark mode was selected in the extension settings. I switched it to "auto", in case I want to work in a very bright environment (e.g. outdoors).

However, when I switch my systems settings to bright, the ERD canvas stays in dark mode and there is no way to manually switch it either. VS Code switches into bright mode, because I have configured it to be "auto".

If I switch to "light" in the Extension Settings, it stays in dark mode too, even after restarting the extension host or VS Code all together.

To Reproduce Steps to reproduce the behavior:

  1. Go to Settings and search for @ext:dineug.vuerd-vscode or open the Extension Settings directly
  2. Switch Theme: Appearance to anything
  3. (Optional) Restart VS Code or VS Code extension host
  4. Open your your-database.vuerd.json file, it will be in dark mode

Expected behavior The settings should be respected. The option "auto" should either listen to VS Code or the System theme settings.

Screenshots grafik

Browser (please complete the following information):

VSCode (please complete the following information):

Additional context Freshly installed the extension today. Looks very nice otherwise!

dineug commented 3 months ago

Legacy is not supported. Try the following database.erd.json

boris-schwarz commented 3 months ago

That did the trick, thanks a lot!