search

dingmaotu / mql-zmq

ZMQ binding for the MQL language (both 32bit MT4 and 64bit MT5)
Apache License 2.0
553 stars 301 forks source link

Duplicate api make confuse #11

Closed janckerchen closed 6 years ago

janckerchen commented 6 years ago

Socket::register vs Socket::fillPollItem

void Socket::register(PollItem &pollitem,bool read=false,bool write=false)
  {
   ZeroMemory(pollitem);
   pollitem.socket=m_ref;
   if(read) pollitem.events|=ZMQ_POLLIN;
   if(write) pollitem.events|=ZMQ_POLLOUT;
  }

void Socket::fillPollItem(PollItem &item,short events)
  {
   item.socket=m_ref;
   item.fd=0;
   item.events=events;
   item.revents=0;
  }
dingmaotu commented 6 years ago

Thank you for reporting this. Socket::register is deprecated and removed.