mwguerra
commented
1 year ago Hi! I was getting acquainted with your package and found what I believe to be the root cause (incredible job, by the way! I'm loving it!).
What I found is that some PHP classes extend from WordPress classes but with no indication of the return code or a signature mismatch in some methods. Starting in PHP 8.1 not being explicit on the return types (or returning anything different from the parent method) leads to a deprecation notice and untreated errors.
In my case running integration tests was returning errors because of that. All the problems I found was in the WP SQLite DB package. Manually editing the db.php file and adding some #[\ReturnTypeWillChange] annotation solved the problem (for now). I’ll send a pull request asking for solving that there in the afternoon.
So the solution, for now, is to solve those signature mismatches. For example:
/**
* This class extends PDO class and does the real work.
*
* It accepts a request from wpdb class, initialize PDO instance,
* execute SQL statement, and returns the results to WordPress.
*/
class PDOEngine extends PDO {
…
/**
* Method to call PDO::rollBack().
*
* @see PDO::rollBack()
*/
public function rollBack() {
$this->pdo->rollBack();
$this->has_active_transaction = false;
}Since the overwritten method PDO::rollBack() returns a boolean, the two possible solutions are:
#[\ReturnTypeWillChange]
public function rollBack() {
$this->pdo->rollBack();
$this->has_active_transaction = false;
}or
public function rollBack() {
$value = $this->pdo->rollBack();
$this->has_active_transaction = false;
return $value
}Both ways make it compliant but only returning the right value will make it ready for the next PHP 9.
I hope I’ve helped in any way! Best regards and thank you for sharing this plugin!
dingo-d
Describe your feature request
Check if the package works with PHP 8.1, currently the tests are failing with some weird patchwork issue.
Describe the solution you'd like
Make the test pass, and ensure the package works with PHP 8.1
Please confirm that you have searched existing issues and discussions about this feature.
Yes