dingo-d / wp-pest

A package that will add WordPress integration test suite with Pest
MIT License
119 stars 5 forks source link

WordPress 6.5 compatibility #35

Open jmotes opened 4 months ago

jmotes commented 4 months ago

Describe your bug

Our integration tests have started failing with the message "Error: WordPress 6.5 requires MySQL 5.5.5 or higher" since the release of WP 6.5.

Is there anything that can be done here to fix this or is this an issue with aaemnnosttv/wp-sqlite-db?

EDIT: I did find the --wp-version flag and have adjusted our CI/CD pipeline to use 6.4.3, but we'll eventually need to test against 6.5 as well.

Let me know if there's anything I can help with!

Steps to Reproduce

Run an integration test.

Expected behavior

Tests should run.

Screenshots, screen recording, code snippet

image

Environment info

Please confirm that you have searched existing issues in this repo.

Yes

dingo-d commented 4 months ago

I got that report by a colleague yesterday as well, but hadn't had the time to test out what is failing and why. I see that the minimum required version was changed, but the package uses sqllite dropin so I'm not 100% sure where's the issue

jkudish commented 4 months ago

Same issue here, tried manually installing mysql in the github action, but it didn't work since wp-pest isn't "aware" of it I think. For now will stick to 6.4.3

You can view the failed github action here if it helps you to troubleshoot @dingo-d https://github.com/metorikhq/metorik-helper/actions/runs/8747937974/job/24007168134?pr=183

Feel free to let me know if there's anything else I can provide, help test, etc. I'm eager to get this working for our plugin

matapatos commented 3 months ago

As @dingo-d mentioned there was a bump in the MySql minimum version. So, this issue should remain until this PR in wp-sqlite-db is merged.

dingo-d commented 2 months ago

Ok so I've forked the wp-sqlite-db package, so in your plugin/theme, to make this work, you'll have to add

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/dingo-d/wp-sqlite-db"
        }
    ],

So that my version of the package is downloaded when the wp-pest package is used. I also released v1.7.0 with this fork in it.

Let me know if there are any issues, integration tests seem to be working for me now.

jkudish commented 2 months ago

Thanks for adding 6.5 support @dingo-d - sorry for the delay as I was away for a bit. I'm using v2-alpha, can you tag an update of v2 with the wp-sqlite-db update?