dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
55 stars 18 forks source link

Use `lalsimulation` frame conversion for IMRPhenomXPHM #108

Open stephengreen opened 2 years ago

stephengreen commented 2 years ago

IMRPhenomXPHM modes are given in the J frame and must be converted to the L0 frame in order to sample the synthetic phase. This requires knowing the Euler angles that specify the transformation. At present, Dingo implements the calculation of these angles, but due to minor discrepancies in PN orders, this leads to mismatches up to 1e-3 (but typically much smaller). It would therefore be better to use the implementation in lalsimulation in SimIMRPhenomXPMSAAngles.