I am working on documentation, and had a couple comments / questions regarding the ASD dataset generation, particularly the config file:
It would be good to remove the outermost dataset_settings level in the config file. Since there is only one key at the outermost level, it does not need to be there.
The f_s option is a bit unclear. Does this specify the data channel (4k vs 16k) to use? Or is it implicitly specifying the Nyquist frequency at which to truncate the ASDs? Looking at the code, I'm not sure it would be consistent if we chose anything other than 4k here.
I am working on documentation, and had a couple comments / questions regarding the ASD dataset generation, particularly the config file:
dataset_settings
level in the config file. Since there is only one key at the outermost level, it does not need to be there.f_s
option is a bit unclear. Does this specify the data channel (4k vs 16k) to use? Or is it implicitly specifying the Nyquist frequency at which to truncate the ASDs? Looking at the code, I'm not sure it would be consistent if we chose anything other than 4k here.