dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
55 stars 18 forks source link

Creating Fresh Environment fails due to pycondor version mismatch #118

Closed nihargupte-ph closed 1 year ago

nihargupte-ph commented 1 year ago

There seems to be some kind of version mismatch when trying to install on python 3.8.10 due to a package cryptography which is required by pyopenssl. Pyopenssl is required by pycondor.

ERROR: pyopenssl 22.1.0 has requirement cryptography<39,>=38.0.0, but you'll have cryptography 36.0.2 which is incompatible.

Steps to reproduce clone the repo and run

$ python3 -m venv venv
$ source venv/bin/activate

$ pip install wheel
$ python setup.py bdist_wheel
$ pip install -e ."[dev]"

For whatever reason, this breaks pip to the point where even running pip --help in the terminal gives an error. This means you have to delete the venv and reinstall.

TypeError: deprecated() got an unexpected keyword argument 'name'

Fix is to do add "cryptography==38.0.0", before installing pycondor in setup.py. I can open a PR for this or can just merge it when doing the calibration weighting PR if it's too small of a fix. Just creating an issue in case someone else runs into this issue.

Also note sure if anyone else is having this issue but LAL fails for me with segmentation fault (core dumped) unless I use numpy==1.19.1

stephengreen commented 1 year ago

Thanks for pointing this out! Based on our discussion today, maybe the best approach is to specify the version of pyOpenSSL, and remove this once the conflicting software is updated to use a newer version. @jonaswildberger Which version did you need?

I think it's best to make a separate PR, since it's an independent issue from the calibration weighting.