search

dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
55 stars 18 forks source link

fixing setup.py to not break pip when creating new virtual environment #121

Closed nihargupte-ph closed 1 year ago

nihargupte-ph commented 1 year ago

Simple-hotfix (refer to linked issue)

stephengreen commented 1 year ago

Thanks Nihar. In the Issue discussion, it sounded like maybe it would be best to specify the version of pyOpenSSL. Is there a reason you chose cryptography instead?

nihargupte-ph commented 1 year ago

The main reason was that I wasn't sure what the correct PyOpenSSL version was whereas I was able to figure out the cryptography version. I think cryptography is the deeper package mismatch but specifying the PyOpenSSL version probably works too

nihargupte-ph commented 1 year ago

Looking into this more seems like we can have an updated version of PyOpenSSL as long as cryptography is set to the correct version: https://pypi.org/project/pyOpenSSL/ since 22.0.0 supports min cryptography 35.0. That being said maybe using poetry or conda for package installation at some point would be good so we can avoid these dependency issues