Closed jonaswildberger closed 1 year ago
I've just added the latest condor arguments and removed the "plot-trace" + redundant "request_gpus" setting.
Hi folks, I've just had a quick glance over this, and it looks sane.
My one piece of advice would be to change the way that you're handling the template file so that it doesn't need to be specified in the asimov.conf
file, but is instead included with the package.
You can see an example of that here which would reduce the amount of configuration required.
@jonaswildberger Could you please address the existing conversations, and then update the Asimov interface to reflect the latest dingo-pipe? DM me to discuss as needed.
Added the interface with Asimov (https://git.ligo.org/asimov/asimov). This includes (1.) the file
dingo/pipe/asimov.py
and (2.) a templateddingo.ini
file, which contains a template of all inference settings, i.e. asimov configuration can override certain settings based on specific events.dingo/pipe/asimov.py
file contains the classDingo(Pipeline)
, which subclassesasimov.pipeline.Pipeline
overriding certain methods according to the Dingo interface. Most importantly, this includes the methodsbuild_dag()
andsubmit_dag()
, which are called as part of generating and submitting the DAG in the asimov workflow. Most of the methods are implemented similarly to Bilby.asimov.conf
(see below)To set up Asimov with Dingo, you need to perform the following steps
pip install asimov==v0.4.0b3
for the most recent version (06.12.22). Also, if using a source install of Dingo, make sure to re-runpython install -e ."[dev]"
such that asimov sees the entrypoint fordingo_pipe
dingo.ini
file to theasimov.conf
:asimov apply -f https://git.ligo.org/asimov/data/-/raw/main/defaults/production-pe.yaml
asimov apply -f https://git.ligo.org/asimov/data/-/raw/main/events/gwtc-2-1/GW150914_095045.yaml
dingo-analysis.yaml
and tell Asimov to use a Dingo production for this event:asimov apply -f dingo-analysis.yaml -e GW150914_095045
dingo-analysis.yaml
asimov manage build
andasimov manage submit
to start the submission. For a more detailed explanation, see https://asimov.docs.ligo.org/asimov/master/getting-started.htmlTODOs