search

dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
55 stars 18 forks source link

Add calibration uncertainty marginalization to dingo-pipe #167

Closed stephengreen closed 1 year ago

stephengreen commented 1 year ago

This pull request adds the ability to marginalize over detector calibration uncertainty to dingo-pipe. This takes place during the importance sampling stage.

It adds the following keys to the INI files:

Usage is explained in the documentation. It should be noted that these have slightly different interpretation than in bilby-pipe, where one typically performs inference over the calibration parameters rather than marginalizing over them.

In addition, there was a small refactoring of the calibration marginalization code to simplify it.

@jonaswildberger You probably need to update #131 to accommodate these additional INI keys.

nihargupte-ph commented 1 year ago

Looks good overall! I will test things out a bit more tomorrow. Saraswati seems to not be able to ping github.com at the moment...