search

dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
55 stars 18 forks source link

Fix bug in `get_mismatch` #171

Closed max-dax closed 1 year ago

max-dax commented 1 year ago

Our get_mismatch function dingo.gw.gwutils would permanently whiten the input when an ASD was provided, which would lead to downstream bugs if the waveform data is used for anything else after whitening. I fixed this, and also added support for batched data (frequency axis is as always -1).

max-dax commented 1 year ago

We should probably use it here https://github.com/dingo-gw/dingo/blob/2d6cc239ee2b9a2eddac04bf943d236dcf54c67c/dingo/gw/SVD.py#L116.