search

dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
55 stars 18 forks source link

hdf5 locking fix #192

Closed nihargupte-ph closed 1 year ago

nihargupte-ph commented 1 year ago

For some reason a fresh install of dingo and executing dingo_pipe on a .ini file gives an error stating that a BilbyMainInput doesn't have a disable_hdf5_locking attribute. I'm not actually sure if this should be set from the command line arguments via args.disable_hdf5_locking, but setting it to None fixes the issue.

mpuerrer commented 1 year ago

Could this be a problem that is specific to AEI clusters? Do you get the same issue on your laptop or on CIT?

nihargupte-ph commented 1 year ago

Could this be a problem that is specific to AEI clusters? Do you get the same issue on your laptop or on CIT?

It seems to happen on my laptop as well, I'm not sure why... I'll link an issue and provide the traceback.

stephengreen commented 1 year ago

I have have implemented changes corresponding to

https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/529 https://git.ligo.org/lscsoft/bilby_pipe/-/merge_requests/534

dingo_pipe requires bilby_pipe >= 1.0.9 to work now, so this is a requirement in pyproject.toml.

Please check that dingo_pipe works, since I have not tested these changes.

nihargupte-ph commented 1 year ago

Please check that dingo_pipe works, since I have not tested these changes.

Works on my local machine