dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
55 stars 18 forks source link

Restore compatibility for bilby_pipe < 1.0.9 #195

Closed stephengreen closed 1 year ago

stephengreen commented 1 year ago

For compatibility with bilby_pipe >= 1.0.9, we assumed an attribute of the Input class called disable_hdf5_locking in #192. However, this introduced an incompatibility with older version of bilby_pipe. This new PR simply gives a default attribute value of None by accessing via getattr().

I am currently testing with bilby_pipe = 1.0.7 and bilby_pipe = 1.1.0.

stephengreen commented 1 year ago

Tested, works fine.