Fix bug in conversion of spin angles to Cartesian spins for new waveform interface (SEOBNRv5PHM)

dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations

MIT License

55 stars 19 forks source link

Fix bug in conversion of spin angles to Cartesian spins for new waveform interface (SEOBNRv5PHM) #212

Closed nihargupte-ph closed 1 year ago

nihargupte-ph commented 1 year ago

For v5 waveforms the spins were not being converted properly. This was due to the fact that the masses did not have the correct dimensions in the bilby_to_lalsimulation_spins function.