dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
51 stars 16 forks source link

Parallelize post-processing change of spin-conversion-phase #213

Open stephengreen opened 11 months ago

stephengreen commented 11 months ago

Dingo and Bilby use different conventions for using the phase parameter in converting between PE and Cartesian spins. (Dingo typically fixes it to 0, whereas Bilby uses the actual phase parameter.) This makes comparing final posteriors difficult, hence we have a method gw.result.Result.get_samples_bilby_phase to convert. In turn, this uses gw.conversion.spin_conversion.change_spin_conversion_phase.

This update simply parallelizes this function, since it is somewhat slow.

Note: This does not speed up the property gw.result.Result.pesummary_samples, since it is not clear how to pass the num_processes argument to a property. It would be good to accelerate also this property, since this is ultimately called by PESummary.