dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
51 stars 16 forks source link

Trigger Offset Bug #215

Open nihargupte-ph opened 10 months ago

nihargupte-ph commented 10 months ago

When downloading data with gwpy, one has to specify the start time of the detector. In dingo pipe, this is set to the trigger time. Usually, this is fine, but there are cases where one specifies a start time of say 1264316116.4 but because of the discretization of the signal, the actual start time is 1264316110.3999023.

This is important as when one projects the waveforms onto the detector, one should be using the correct start time of the detector. Otherwise, this will create an incorrect log likelihood (or at least a log likelihood which is consistent with the trigger time but not the start time).

This patch aims to fix this by specifying a trigger offset which changes the time translation of the signal according to the start time of the detector.