Open stephengreen opened 9 months ago
The prior evaluations at each sample point should change when changing the spin_conversion_phase in https://github.com/dingo-gw/dingo/blob/c9bf1ec2846b869584f0ec65f8144d8192beb5e8/dingo/gw/conversion/spin_conversion.py#L130 This is because the prior over phi_jl is non-uniform. If log_weights are already stored, they should be updated as well.
spin_conversion_phase
phi_jl
log_weights
The likelihood, however, is unchanged. As is the evidence.
The prior evaluations at each sample point should change when changing the
spin_conversion_phasein https://github.com/dingo-gw/dingo/blob/c9bf1ec2846b869584f0ec65f8144d8192beb5e8/dingo/gw/conversion/spin_conversion.py#L130 This is because the prior overphi_jlis non-uniform. Iflog_weightsare already stored, they should be updated as well.The likelihood, however, is unchanged. As is the evidence.