search

dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
51 stars 16 forks source link

Set `spin_conversion_phase = 0.0` for NPE and GNPE examples #223

Closed stephengreen closed 8 months ago

stephengreen commented 9 months ago

These examples fail when sampling the synthetic phase since they defaulted to spin_conversion_phase = None.

stephengreen commented 9 months ago

We should also document this setting (in the waveform dataset generation part of the docs) and possibly print a warning when training a phase-marginalized network with spin_conversion_phase != 0.0.

stephengreen commented 9 months ago

Updated the docs.

mpuerrer commented 8 months ago

This PR fixed the issue we had earlier.