search

dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
51 stars 16 forks source link

Update to bilby pipe 1.2.1 #224

Closed stephengreen closed 8 months ago

stephengreen commented 8 months ago

This brings dingo_pipe up to date with bilby_pipe==1.2.1. The main change is that the data generation step now transfers files over from elsewhere.

Closes #221

Possible issues

  1. When running, I get the following warning, although it still seems work:

    10:01 dingo_pipe INFO    : Running: gwdatafind.find_urls(site='H', frametype='H1_HOFT_C02', gpsstart=1126259456.4, gpsend=1126259464.4, urltype='osdf', host='https://datafind.ligo.org', )
10:01 dingo_pipe WARNING : Failed to resolve frame files for detector H1
10:01 dingo_pipe INFO    : Running: gwdatafind.find_urls(site='L', frametype='L1_HOFT_C02', gpsstart=1126259456.4, gpsend=1126259464.4, urltype='osdf', host='https://datafind.ligo.org', )
10:01 dingo_pipe WARNING : Failed to resolve frame files for detector L1

  2. Now now the environment variable OMP_NUM_THREADS==1 by default. We were carefully managing our threads in Dingo, so we should be sure that this does not result in any slowdowns during multithreading. Can @max-dax @jonaswildberger remember where this might be an issue?

Actions

@hectorestelles Please test to make sure this works for you with both the new and old versions of bilby_pipe. If it does not work with old bilby_pipe, then we should pin the version.