dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
51 stars 16 forks source link

Choose correct `wfg_domain` during importance sampling #225

Closed stephengreen closed 8 months ago

stephengreen commented 8 months ago

When we update data conditioning settings during importance sampling, we need to carefully update the domain objects.

There are two relevant domain objects in Dingo:

Previously, we were simply using the data domain directly whenever making an update to data conditioning during importance sampling. This is clearly wrong, so it has been corrected.

Closes #222

@hectorestelles Please test and confirm that the problem in #222 is resolved.

hectorestelles commented 8 months ago

This PR seems to solve the issue found in #222 , I could successfully run SEOBNRv5PHM with f_max=972.0

stephengreen commented 8 months ago

To clarify the behavior now:

Future to-do:

@hectorestelles Once you're happy with this, please approve the PR.