Closed stephengreen closed 8 months ago
This PR seems to solve the issue found in #222 , I could successfully run SEOBNRv5PHM with f_max=972.0
To clarify the behavior now:
duration
is specified in the INI file, we update delta_f = 1 / duration
for the data domain and the waveform generator.minimum-frequency
or maximum-frequency
are specified, we update corresponding quantities in the data domain.tukey-roll-off
, sampling-frequency
, or duration
are specified, we use these in conditioning the data and update the window factor.approximant
is specified we raise an error.@hectorestelles Once you're happy with this, please approve the PR.
When we update data conditioning settings during importance sampling, we need to carefully update the domain objects.
There are two relevant domain objects in Dingo:
wfg_domain
must be suitably truncated, e.g., iff_max
is reduced. For most updates to data conditioning, we update the data domain. However, to maintain compatibility between the domains, we sometimes need to update thewfg_domain
. This PR setswfg_domain.delta_f
to match that of the data domain.Previously, we were simply using the data domain directly whenever making an update to data conditioning during importance sampling. This is clearly wrong, so it has been corrected.
Closes #222
@hectorestelles Please test and confirm that the problem in #222 is resolved.