dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
51 stars 16 forks source link

Update pyproject.toml dependencies #229

Closed stephengreen closed 8 months ago

stephengreen commented 8 months ago

Adding the following dependencies, which are explicitly used in the code:

Removing:

@nihargupte-ph I think you added cryptography and pyopenssl in #121, where you put a fixed version. Is this still needed?

stephengreen commented 8 months ago

asimov also depends on htcondor, which on pypi only exists for Linux. Maybe we should not have asimov as a dependency then. In that case, we should handle the imports appropriately.

@max-dax @jonaswildberger What do you think?

mpuerrer commented 8 months ago

I think we should avoid requiring dependencies such as htcondor because it is not needed for all use cases of dingo and will make it hard for people to try out the code. Such dependencies should be optional and could be listed in the README and docs.

stephengreen commented 8 months ago

Good point, I removed Asimov from the dependencies.