search

dingo-gw / dingo

Dingo: Deep inference for gravitational-wave observations
MIT License
51 stars 16 forks source link

Hotfix for dingo_pipe data_generation #236

Closed nihargupte-ph closed 4 months ago

nihargupte-ph commented 4 months ago

I am not sure when this bug got introduced, but with the current and previous versions of bilby_pipe, we need to specify args.gaussian_noise and not self.gaussian_noise to be False. Otherwise, this will trigger an error in the data_generation. Namely, see the following line of the bilby source code which is called after running self.create_data https://github.com/lscsoft/bilby_pipe/blob/master/bilby_pipe/data_generation.py#L211.

stephengreen commented 4 months ago

Hm, I don't see the offending line in the current version of bilby_pipe, see create_data() here:

https://git.ligo.org/lscsoft/bilby_pipe/-/blob/master/bilby_pipe/data_generation.py#L211.

The github version of bilby_pipe that you linked is three years old. In our pyproject.toml we only support bilby_pipe>=1.3; are you running an old version?

nihargupte-ph commented 4 months ago

Hm, I don't see the offending line in the current version of bilby_pipe, see create_data() here:

https://git.ligo.org/lscsoft/bilby_pipe/-/blob/master/bilby_pipe/data_generation.py#L211.

The github version of bilby_pipe that you linked is three years old. In our pyproject.toml we only support bilby_pipe>=1.3; are you running an old version?

You are right, in this case I don't think this PR makes sense. Closing it!