search

dingo / api

A RESTful API package for the Laravel and Lumen frameworks.
BSD 3-Clause "New" or "Revised" License
9.33k stars 1.25k forks source link

Set challenge parameter on UnauthorizedHttpException #1526

Closed MithrandirDK closed 6 years ago

MithrandirDK commented 6 years ago

the first parameter of Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException can not be null in Symfony 4.

vokomarov commented 6 years ago

Got this when tried to use authenticated route without authentication header. Please, @jasonlewis merge this as soon as possible. Thanks.

thilanga commented 6 years ago

@MithrandirDK can update your PR with Style CI fix?

MithrandirDK commented 6 years ago

@thilanga What Style CI fix? Travis failed, but as far as I can see, it has nothing to do with my code. My change is literally changing a null value to a string

fbingha commented 6 years ago

I see this change was reverted, regardless, the 'null' needs to be replaced with a string. I had to do this on my own codebase with Laravel 5.6

thilanga commented 6 years ago

Changes were reverted coz unit tests are failing. Need to fix unit tests before merge PRs.

fbingha commented 6 years ago

I looked at the details of that failure and I don't see anything related to change that was made.

thilanga commented 6 years ago

@fbingha can you do a PR to fix unit tests. At the moment I can't attend to it. Are you happy to usethe project while the build is failing? If that's ok I'll merge the PR to get things moving

thilanga commented 6 years ago

PR #1531 has fixed UnitTests. PF #1526 has been merged to master

@MithrandirDK @VovikeMS @fbingha

vokomarov commented 6 years ago

@thilanga Thanks for a quick merge of this fix, how i can install the fixed version by composer? When do you think v2.0.0-alpha2 will be released?

thilanga commented 6 years ago

I'll get it done as soon as possible. Thanks for the support. Need to test is personally before doing a release.😋

guiassemany commented 6 years ago

Hi Guys! Any news about this?