search

dingo / api

A RESTful API package for the Laravel and Lumen frameworks.
BSD 3-Clause "New" or "Revised" License
9.33k stars 1.25k forks source link

Laravel framework included event using lumen #1638

Closed lloricode closed 5 years ago

lloricode commented 5 years ago
Q A
Bug? yes
New Feature? no
Framework Lumen
Framework version 5.8.*
Package version 2.2.0
PHP version 7.3.3

Actual Behaviour

@specialtactics I think here https://github.com/dingo/api/blob/v2.2.0/composer.json#L21 no need to include laraver/framework 

    "require": {
        "php": "^7.1",
        "dingo/blueprint": "^0.2",
        "illuminate/routing": "^5.5",
        "illuminate/support": "^5.5",
        "league/fractal": "^0.17",
        "laravel/framework": "^5.5"
    },

Expected Behaviour

    "require": {
        "php": "^7.1",
        "dingo/blueprint": "^0.2",
        "illuminate/routing": "^5.5",
        "illuminate/support": "^5.5",
        "league/fractal": "^0.17"
    },
specialtactics commented 5 years ago

Hi @lloricode

I think this should work fine, approved.