Laravel 6 Updates

[mycarrysun]

Changes:

• Removed deprecated functions starting with str_ and arr_ docs
• Update composer.json to allow ^6.0 versions of Illuminate packages

Fixes

• Cast return value of $response->headers->get() to (int) for assertSame comparison in RateLimitTest

[lloricode]

then we will wait for release in lumen-framework with laravel 6 components

[leeovery]

Is there anything else we can do to help get this merged? Appreciate we are all busy. Perhaps we need a few more maintainers to help out? I literally waiting on this to get setup with L6 and its making things tricky, having to keep rebasing into my shifted branch.

Please can this be merged? PLEASE!!

[rauanmayemir]

This won't work without dingo/blueprint being updated as well.

[mycarrysun]

@rauanmayemir I saw that...happy to make a PR for that as well. Need a couple of hours though, if someone else can do it before me.

[mycarrysun]

Just pushed a PR for Laravel 6.0 support for dingo/blueprint here

@specialtactics do you have access to merge/create a new release? Just saw that you were the most active contributor this year in this repo

[leeovery]

Who has ownership of this now? I'm very concerned at the speed of implementing a super simple PR. Whoever is running this repo please advertise for help or mark as abandoned.

I'm now spending my time unwinding my code from Dingo due to the lack of updates. I don't want to seem ungrateful. I fully appreciate the time that goes into maintenance. But once a package reaches a certain level of use there comes a certain responsibility to either maintain, recruit help, or officially abandon.

Somebody, please take some action on this repo so we can all either move on or update our stuff.

[jeandormehl]

Any movement on this?

[denisdulici]

@specialtactics any update on this plz?

[mko-tapptic]

Temporary solution. Add this to your composer.json

"repositories": {
    "dingo6": {
        "type": "git",
        "url": "https://github.com/mycarrysun/api.git"
    },
    "dingo-blueprint6": {
        "type": "package",
        "package": {
            "name": "dingo/blueprint",
            "version": "0.2.99",
            "dist": {
                "url": "https://github.com/mycarrysun/blueprint/archive/laravel-6.zip",
                "type": "zip"
            },
            "source": {
                "type": "git",
                "url": "https://github.com/mycarrysun/blueprint.git",
                "reference": "laravel-6"
            },
            "autoload": {
                "classmap": ["src/"]
            },
            "require": {
                "php": ">=5.5.9",
                "illuminate/support": "^5.1 || ^6.0",
                "illuminate/filesystem": "^5.1 || ^6.0",
                "doctrine/annotations": "~1.2",
                "phpdocumentor/reflection-docblock": "^3.1|^4.1"
            },
            "require-dev": {
                "squizlabs/php_codesniffer": "~2.0",
                "phpunit/phpunit": "~4.0"
            }
        }
    }
}

Then just composer require dingo/api:dev-laravel-6

Voilà.

[leeovery]

Another solution? Remove it completely. You honestly don’t need it. Most of what it provides Laravel now gives you out of the box. It’s an awesome package. Truly great. But perhaps it’s had its day. I’m removing it from my stuff. Feels good. Thank you Dingo for your service!! 😘

[Broutard]

Please merge this PR.

@leeovery I use Dingo mainly for the integrated InternalRequest feature which does not exist natively in Laravel.

[m-zanetti]

Temporary solution. Add this to your composer.json

"repositories": {

}

Then just `composer require dingo/api:dev-laravel-6`

@mko-tapptic good idea, @mycarrysun there is a problem when composer executes ` artisan package:discover`:

Symfony\Component\Debug\Exception\FatalThrowableError : Argument 1 passed to Dingo\Api\Http\Response::setFormatters() must be of the type array, null given, called in /home/vagrant/projects/konfronto/vendor/dingo/api/src/Provider/DingoServiceProvider.php on line 34

[specialtactics]

Thanks for your contribution once again, @mycarrysun

Apologies this has been a little bit late, just keep in mind this is open-source development guys. If you would like to help out more with the repo, please do so - that would be great. What more often happens is that people show up at a time like this to complain, but are not actually willing to put in the hard work :smile:

[specialtactics]

I've tagged this PR's master as v2.4.0-rc1, if your minimum stability is dev, you can update now, otherwise wait a little while longer for testing.

[specialtactics]

@m-zanetti In your case, you must be missing the "formats" config in your config/api.php Have a look at the package distributable for an example.

https://github.com/dingo/api/blob/master/config/api.php

[amcsi]

@specialtactics

Apologies this has been a little bit late, just keep in mind this is open-source development guys. If you would like to help out more with the repo, please do so - that would be great. What more often happens is that people show up at a time like this to complain, but are not actually willing to put in the hard work

I appreciate your work, but note that in this case two related Laravel 6.0 PRs had already been open 15 days ago by others. There's no use in the ability to openly contribute if those people don't have PR merging rights :P

[specialtactics]

@amcsi I can't give them or anyone else merging rights, and I don't think it would be appropriate in any case. 15 days is not much in the grand scheme of things, please have some understanding.

[denisdulici]

@specialtactics Thanks Max for merging this PR. However, it's still not compatible with Laravel 6 due to blueprint #1680. Can you please re-open and merge that PR?

[specialtactics]

@denisdulici Can you elaborate? That PR was merged even before this one.

[lloricode]

@specialtactics Thanks Max for merging this PR. However, it's still not compatible with Laravel 6 due to blueprint #1680. Can you please re-open and merge that PR?

@denisdulici cannot reopned to merge because the repository already not existing