search

dingo / api

A RESTful API package for the Laravel and Lumen frameworks.
BSD 3-Clause "New" or "Revised" License
9.32k stars 1.25k forks source link

Laravel 8 Support? #1745

Closed khanhvu14 closed 3 years ago

khanhvu14 commented 3 years ago

Laravel 8 has just realeased, can add new tag support it?

Vivian-A commented 3 years ago

I can't get it to install on Laravel 8 unfortunately. Composer spews out a ton of errors, most of which say "Don't install laravel/framework v8.0.0" or "Remove laravel/framework v8.0.0".

specialtactics commented 3 years ago

Would you guys mind pulling in this commit locally and testing with your project and Laravel 8?

I will do the same testing, but I want as many people as possible to test to find issues before we push support live.

https://github.com/dingo/api/commit/660fd77164fb4c61981f94d78e5cea67212a16ce

bbashy commented 3 years ago

@specialtactics Just tested with newly upgraded project using "dingo/api": "dev-master#660fd77164fb4c61981f94d78e5cea67212a16ce", and it works fine by the looks of it. Got a few routes with a custom guard (sanctum) and no errors.

specialtactics commented 3 years ago

Thanks for your help @bbashy

Just in case people might be looking over this, I will set a deadline of 21st of September of when I will tag it, assuming no errors are uncovered from testing.

gazben commented 3 years ago

@specialtactics Did you find any errors? Can you tag the next version?

anardil commented 3 years ago

@specialtactics any news about the support of Laravel 8?

specialtactics commented 3 years ago

Tagged here guys ! https://github.com/dingo/api/releases/tag/v3.0.2-rc1

gtjamesa commented 3 years ago

All API tests are passing on my application with custom guards 👍 Thanks for tagging @specialtactics

khanhvu14 commented 3 years ago

Thanks @specialtactics I tested about 2 weeks with small and medium projects. Everything seems work well.

specialtactics commented 3 years ago

If anyone ends up having any problems relating to laravel 8, feel free to report as a new issue.