Elasticquent pagination and fractal

[drauta]

Hi, I'm using elasticquent/Elasticquent to do search queries. If you do a search on the model, add pagination and apply a transformer, in the fractal adapter from dingo makes a call to inexistent function:

Line 89 on dingo/api/src/Transformer/Adapter/Fractal.php:

if (($response instanceof EloquentCollection || $response instanceof IlluminatePaginator) && $this->eagerLoading) {
            $eagerLoads = $this->mergeEagerLoads($transformer, $this->fractal->getRequestedIncludes());
            $response->load($eagerLoads);
        }

The call to $response->load() fails because the collection is an instance of Illuminate\Support\Collection instead of Illuminate\Database\Eloquent\Collection.

In order to solve this I added a condition to the if:

if (($response instanceof EloquentCollection || $response instanceof IlluminatePaginator) && $this->eagerLoading && method_exists($response->getCollection(), 'load')) {
            $eagerLoads = $this->mergeEagerLoads($transformer, $this->fractal->getRequestedIncludes());
            $response->load($eagerLoads);
        }

In summary: when you do pagination on a Illuminate\Support\Collection the fractal paginator fails.

Thank you!!

[jasonlewis]

Okay no worries I'll need to account for that as well. Cheers.

[drauta]

The workaround I posted yestarday fails in some cases, this not:

if ( ($response instanceof EloquentCollection || ($response instanceof IlluminatePaginator &&
method_exists($response->getCollection(), 'load') ) ) && $this->eagerLoading ) 
{
    $eagerLoads = $this->mergeEagerLoads($transformer, $this->fractal->getRequestedIncludes());
    $response->load($eagerLoads);
}

[jasonlewis]

Indeed. No worries I'll have something up when I can.

[drauta]

Thank you!

[andreygrehov]

This is indeed an issue for larger projects, where not only an eloquent collections are used, but hand-made collections of entity objects.

[jasonlewis]

This should've been fixed with cda184a566d9b68f47d4edff51b43ba8f56bbc3c so that it only attempts to eager load Eloquent collections.