search

dingo35 / SmartEVSE-3.5

Smart Electric Vehicle Charging Station (EVSE)
MIT License
47 stars 21 forks source link

Solar countdown timer published on MQTT #113

Closed Imaginous closed 2 months ago

Imaginous commented 3 months ago

Describe the solution you'd like Is it possible to publish the solar countdown timer on MQTT. I want to use this to lower the changing level of my Tesla just before the timer expires. This way it won't nag me with unnesecary "Charging stopped unexpectedly" messages.

Describe alternatives you've considered I now use my own timer in parallel with an offset, but I would be nice if I could rely on the timer of the SmartEVSE.

Additional context Keep up the good work!

dingo35 commented 3 months ago

Please test:

39d875b4052f.zip

Please do not only test the new SolarStopTimer topic, but also check the other ones; I changed the calls to MQTT.publish, it should have no effect but you never know !

Imaginous commented 3 months ago

MQTT is posting correctly.

Maybe only post the timer when it has changed since the last update. It's now continously updating when it's zero.

Can't test the timer yet, because the car is fully charged.

Imaginous commented 3 months ago

There might be a logic problem with the count down timer. It now is 0 when the timer is inactive. I think it should be the set MAX TIMEOUT (or -1) when it is not counting and the car is charging in solar mode.

Now we (I) can't see the difference between an expired timer and a non triggered timer.

I don't know what you think of it.

dingo35 commented 3 months ago

You can tell the difference by checking solar_stop_time, that tells you if the timer has been set.

To keep the logic simple there is no difference between an expired timer and an unset timer.

Also you could take State into account, that is C when charging and turns to C1, when waiting for solar.

Imaginous commented 2 months ago

After testing I think this feature works fine and can be in the next official release.