vibhorB
commented
10 years ago Good work Quan. A few notes after checking out the code:
- Properly reused the single base method in search activity to fetch results for both initial load and the pagination
- Nice to see you added the search box to the ActionBar alongwith Voice support
- Properly used spinners (with populated values) to allow users to select filters
- Good job with error handling
- Using filters as overlay model looks great
- Good work saving settings to SharedPrefs
- Consider better organizing your source files
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
Please review the app code. /cc @nesquena @thecodepath
User can enter a search query that will display a grid of image results from the Google Image API. User can click on "settings" which allows selection of advanced search options to filter results User can configure advanced search filters such as: Size (small, medium, large, extra-large) Color filter (black, blue, brown, gray, green, etc...) Type (faces, photo, clip art, line art) Site (espn.com) Subsequent searches will have any filters applied to the search results User can tap on any image in results to see the image full-screen User can scroll down “infinitely” to continue loading more image results (up to 8 pages) The following advanced user stories are optional:
Advanced: Robust error handling, check if internet is available, handle error cases, network failures Advanced: Use the ActionBar SearchView or custom layout as the query box instead of an EditText Advanced: Replace Filter Settings Activity with a lightweight modal overlay Advanced: Improve the user interface and experiment with image assets and/or styling and coloring