Added functionality for noteFromMidiPitch

dingram / jsmidgen

A pure-JavaScript MIDI generator

228 stars 33 forks source link

Added functionality for noteFromMidiPitch #2

Closed walmik closed 9 years ago

walmik commented 10 years ago

Added function to return Midi note from pitch. Rearranged exports mechanism. Added a test script to output all notes for pitches from 21 to 108.

dingram commented 9 years ago

Looks good, I think. I'll have a play and merge it soon.

Thanks for contributing!

walmik commented 9 years ago

Sure thing. Please do lemme know if you need me to improve something in the PR. I m super keen on contributing to this repo :)

dingram commented 9 years ago

My main comments are style-based. Can you update your code and comments to conform to the style of the rest of the file, please? It's mainly use of whitespace.