search

dingusdev / dingusppc

An experimental emulator
GNU General Public License v3.0
200 stars 21 forks source link

Upstream small changes from the Infinite Mac fork #54

Closed mihaip closed 8 months ago

mihaip commented 8 months ago

I thought it would be easier to start with a few small commits. Once I understand the process better, I can do bigger ones like ADB keyboard support.

The commits are not related (and should not be squashed when merging). This saves me some boilerplate with branch/PR creation, but happy to do them as separate PRs if you prefer.

maximumspatium commented 8 months ago

LGTM except fbce00c that includes unrelated changes to set_fatal_handler(). Please split them into separate commits. I'd replace those out-of-bounds checks with asserts so the proper API usage is ensured but the production code won't include them.

mihaip commented 8 months ago

LGTM except fbce00c that includes unrelated changes to set_fatal_handler(). Please split them into separate commits.

Good point, done.

I'd replace those out-of-bounds checks with asserts so the proper API usage is ensured but the production code won't include them.

I switched them to DCHECK_F, is that what you had in mind (I didn't see any other uses of that macro)?

dingusdev commented 8 months ago

Everything looks good here. If no one objects to the use of DCHECK_F, I'll merge it.