dingusdev / dingusppc

An experimental emulator
GNU General Public License v3.0
200 stars 21 forks source link

[BUG] Compile issues in openSUSE #65

Closed Lucas-mother3 closed 6 months ago

Lucas-mother3 commented 7 months ago

Describe the bug DingusPPC release builds failed to build under openSUSE Tumbleweed.

To Reproduce Steps to reproduce the behavior:

  1. Follow build instructions on README.md under openSUSE
  2. Wait a while
  3. Compilation should return an error

Expected behavior I expected to have a build of DingusPPC to test whenever it is viable to run Mac OS on it.

Screenshots image

Device Information (please complete the following information):

Additional context Context should be seen in the following screenshot. The screenshot provides the error information much clearly.

dingusdev commented 7 months ago

Looking at that log, it seems like it's trying to compile using the C++11 standard rather than the C++20 one DPPC expects. This can be reverted back to C+11 with minimal effort though.

rndtrash commented 6 months ago

It looks like adding #include <algorithm> to the machineproperties.cpp file solves this issue.


By the way,

using namespace std;

why?

dingusdev commented 6 months ago

Got the fix in. As for those std namespace statements, I could remove most of it and specify it. Though to be fair, it's not as if CubeB didn't do this it.

Lucas-mother3 commented 6 months ago

Closing this issue as I successfully compiled a binary.