dinhanhx / Morphology_Study

A repos for USTH Digital Image Processing 2020 Group 1. It's quite obvious in the title.
1 stars 0 forks source link

Unintuitive names #1

Closed Huy-Ngo closed 4 years ago

Huy-Ngo commented 4 years ago

We have several functions or variables with unintuitive names in very-simple-morphological.py (the filename itself is also unintuitive) which give little idea of what they do.

Here are the ones I think should be renamed:

By the way, type is a builtin function in python, so even though we maybe won't use it, it's best to avoid overwriting that function.

dinhanhx commented 4 years ago

Here are the list I can think of:

For changing the name of the function morp(), I propose that we should call it get_morpheme().

dinhanhx commented 4 years ago

For the name of the file, in stead of calling very-simple-morphological.py, we should change it to morphological_methods.py

huonglarne commented 4 years ago

fixed all, except type argument. i think erosion, dilation and stuff are types of morphological processing. technique is the morphology itself, using structure element and hit/miss. Picture to prove my point.

image

Huy-Ngo commented 4 years ago

Close via fcf3c99