search

dinhchitrung / oauth

Automatically exported from code.google.com/p/oauth
0 stars 0 forks source link

Python: OAuthError definition mostly redundant #127

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Notwithstanding issues #110 and #123, the class definition of OAuthError
seems to be pretty much entirely redundant. A simple `pass`ing class
definition inheriting from Exception would serve exactly the same purpose, no?
The only 'feature' I can see the current definition adding is a default
message ("OAuth error occured"), which is already made entirely redundant
by the name of the class itself - "OAuthError".
It also has the spelling of "occurred" wrong. ;)

I specifically suggest inheriting from Exception rather than the current
RuntimeError, because RuntimeError "is mostly a relic from a previous
version of the interpreter" (so sayeth the Python docs).

Original issue reported on code.google.com by raumkraut on 1 Oct 2009 at 11:41

GoogleCodeExporter commented 9 years ago

Original comment by morten.f...@gmail.com on 5 Jan 2010 at 11:34