dinhminhquoi / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

ThreadSanitizer warnings related to border extension #692

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
SUMMARY: ThreadSanitizer: data race vp9/common/vp9_reconinter.c:52 
build_mc_border

Full log attached.

v1.3.0-633-g4f2a80f

CC=clang \
CXX=clang++ \
LD=clang \
LDFLAGS='-fsanitize=thread' \
./configure \
--extra-cflags='-fsanitize=thread -fsanitize-blacklist=tsan-supp.txt' \
--enable-debug --enable-pic --disable-vp8

The clip I was testing was 4K, but this looks like a more general issue:
$ ./vpxdec --summary --noblit -t 8 ...

Reverting ff2c96b and its dependent commits gets rid of the warning.
ff2c96b Implenment on demand border extension. In place extend the border now. 
Next commit will totally remove the border.

This looks to be the same location that was updated to use memmove in:
1339f38 Fix valgrind error.

Original issue reported on code.google.com by jz...@google.com on 14 Jan 2014 at 4:30

Attachments:

GoogleCodeExporter commented 9 years ago
Issue 693 has been merged into this issue.

Original comment by jz...@google.com on 21 Jan 2014 at 7:28

GoogleCodeExporter commented 9 years ago
I think this is fixed now, Hangyu can you update this with the commit and a 
link to the gerrit change please? It seems your commit message wasn't formatted 
properly to automatically close the issue.

Original comment by jz...@google.com on 22 Jan 2014 at 2:48

GoogleCodeExporter commented 9 years ago
The cause of this issue is due to two tile thread trying to use same reference 
block for reconstruction and the reference block is cross the boarder.  

This issue is fixed by 
https://gerrit.chromium.org/gerrit/#/c/68386/

Original comment by hku...@google.com on 22 Jan 2014 at 6:39