dinhminhquoi / webm

Automatically exported from code.google.com/p/webm
0 stars 0 forks source link

vp8 vpx_codec_enc_config_set should prevent caller from changing dimensions unsafely #763

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What is the expected behavior? What do you see instead?

vp8 vpx_codec_enc_config_set should return error if caller attempts to adjust 
dimensions in a way that leads the encoder to fail in non-deterministic way.  
priv->cx_data is initially sized and allocated according to g_w and g_h but 
isn't resized if the caller adjusts these dimensions via 
vpx_codec_enc_config_set nor is an error returned if cx_data is too small for 
the given dimensions.  encoder eventually fails in validate_buffer because 
cx_data is too small.

its not clear that its safe to realloc cx_data but vpx_codec_enc_config_set 
should let the caller know its passed an invalid configuration.

vp9 does not permit the caller to adjust these dimensions post-initialization 
at all.

What version are you using? On what operating system?

Can you reproduce using the vpxdec or vpxenc tools? What command line are
you using?

Please provide any additional information below.

Original issue reported on code.google.com by aar...@biba.com on 14 Apr 2014 at 8:21

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by renganat...@google.com on 9 Oct 2014 at 10:28

GoogleCodeExporter commented 8 years ago

Original comment by renganat...@google.com on 9 Oct 2014 at 10:28