[svc] valgrind warnings

[GoogleCodeExporter]

v1.3.0-2782-g71854f3
$ valgrind --error-exitcode=1 --leak-check=full \
   --show-reachable=yes --track-origins=yes \
   ./test_libvpx --gtest_filter=SvcTest.FirstFrameHasLayers

Note: Google Test filter = SvcTest.FirstFrameHasLayers-:AVX/*:AVX2/*
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from SvcTest
[ RUN      ] SvcTest.FirstFrameHasLayers
==21635== Conditional jump or move depends on uninitialised value(s)
==21635==    at 0x58AF683: __printf_fp (printf_fp.c:406)
==21635==    by 0x58AC5B7: vfprintf (vfprintf.c:1629)
==21635==    by 0x58D4441: vsnprintf (vsnprintf.c:120)
==21635==    by 0x50377D: svc_log (svc_encodeframe.c:249)
==21635==    by 0x504D07: vpx_svc_encode (svc_encodeframe.c:935)
==21635==    by 0x4C309D: (anonymous 
namespace)::SvcTest_FirstFrameHasLayers_Test::TestBody() (svc_test.cc:267)
==21635==    by 0x62458C: void 
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, 
void>(testing::Test*, void (testing::Test::*)(), char const*) 
(gtest-all.cc:3562)
==21635==    by 0x61C09F: testing::Test::Run() (gtest-all.cc:3635)
==21635==    by 0x61C367: testing::TestInfo::Run() (gtest-all.cc:3810)
==21635==    by 0x61C520: testing::TestCase::Run() (gtest-all.cc:3928)
==21635==    by 0x61CAED: testing::internal::UnitTestImpl::RunAllTests() 
(gtest-all.cc:5799)
==21635==    by 0x61CF64: testing::UnitTest::Run() (gtest-all.cc:3562)
==21635==  Uninitialised value was created by a stack allocation
==21635==    at 0x503667: svc_log (svc_encodeframe.c:238)
==21635== 
==21635== Conditional jump or move depends on uninitialised value(s)
==21635==    at 0x58AFA07: __printf_fp (printf_fp.c:421)
==21635==    by 0x58AC5B7: vfprintf (vfprintf.c:1629)
==21635==    by 0x58D4441: vsnprintf (vsnprintf.c:120)
==21635==    by 0x50377D: svc_log (svc_encodeframe.c:249)
==21635==    by 0x504D07: vpx_svc_encode (svc_encodeframe.c:935)
==21635==    by 0x4C309D: (anonymous 
namespace)::SvcTest_FirstFrameHasLayers_Test::TestBody() (svc_test.cc:267)
==21635==    by 0x62458C: void 
testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, 
void>(testing::Test*, void (testing::Test::*)(), char const*) 
(gtest-all.cc:3562)
==21635==    by 0x61C09F: testing::Test::Run() (gtest-all.cc:3635)
==21635==    by 0x61C367: testing::TestInfo::Run() (gtest-all.cc:3810)
==21635==    by 0x61C520: testing::TestCase::Run() (gtest-all.cc:3928)
==21635==    by 0x61CAED: testing::internal::UnitTestImpl::RunAllTests() 
(gtest-all.cc:5799)
==21635==    by 0x61CF64: testing::UnitTest::Run() (gtest-all.cc:3562)
==21635==  Uninitialised value was created by a stack allocation
==21635==    at 0x503667: svc_log (svc_encodeframe.c:238)
==21635== 
...

---
74e1830b0538d135a65e77e69625033a7111e503 is the first bad commit
commit 74e1830b0538d135a65e77e69625033a7111e503
Author: Ivan Maltz <ivanmaltz@google.com>
Date:   Wed Feb 26 13:27:01 2014 -0800

    log overall psnr, average psnr, and overall mse

    Change-Id: I0b4fa1f8104b7fa5780d4e99e5401c14271a992d

:040000 040000 cff3d22116ecf980ee1a7d5499766612623fa5bb 
73eb256a5ebd815e7a9cc13fa8abf223cc82f12f M      vpx

Original issue reported on code.google.com by jz...@google.com on 15 May 2014 at 7:37

[GoogleCodeExporter]

This was detected for some time, but got lost in the noise I think.

Original comment by jz...@google.com on 15 May 2014 at 7:38

[GoogleCodeExporter]

I can see similar warning at strncat() in svc_log(). But I can't figure out the 
reason.I tried to initialize all local variables but it didn't work.

Original comment by ming...@google.com on 15 May 2014 at 9:37

[GoogleCodeExporter]

Original comment by renganat...@google.com on 15 May 2014 at 10:17

• Changed state: Assigned

[GoogleCodeExporter]

Since
f12ebfc make spatial svc an experiment
https://gerrit.chromium.org/gerrit/#/c/70153/

--enable-experimental --enable-spatial-svc will be needed to enable the tests. 
For now the valgrind runs won't pick this up.

Original comment by jz...@google.com on 20 May 2014 at 11:05

[GoogleCodeExporter]

This issue is still reproducible.

$ git describe
v1.3.0-3241-g0a103ae

$ ../../configure --enable-internal-stats --enable-experimental --enable-debug
$ make
$ valgrind vpx_temporal_svc_encoder input.yuv output vp9 640 360 1 30 6 0 0 600

Partial output (I didn't let it run to completion) is attached.

Original comment by tk...@google.com on 1 Jul 2014 at 8:11

[GoogleCodeExporter]

Original comment by tk...@google.com on 1 Jul 2014 at 8:14

Attachments:

• dump.txt