vpxenc produces different file when default parameters are added to command line

[GoogleCodeExporter]

./vpxenc hantro_collage_w352h288.yuv --width=352 --height=288 --limit=2 --ivf 
-o hantro_a.ivf
./vpxenc hantro_collage_w352h288.yuv --width=352 --height=288 --limit=2 
--lossless=0 --ivf -o hantro _c.ivf

> ls -al hantro _*
-rw-r--r--. 1 pfcd users     2744 May 28 16:34 hantro _a.ivf
-rw-r--r--. 1 pfcd users     2753 May 28 16:35 hantro _c.ivf

Original issue reported on code.google.com by ya...@google.com on 30 May 2014 at 5:24

[GoogleCodeExporter]

The problem was caused by an issue that is explained here: 
https://gerrit.chromium.org/gerrit/#/c/70355/

Because the uninitialized parameter is used in the first call to motion search 
initialization, it defaults to diamond search. And when there is any command 
line parameter is used, the initialization would be done properly later with 
intiialized search method of "NSTEP". This leads to different output. 

The above patch would also fix this issue. 

Original comment by ya...@google.com on 30 May 2014 at 5:27

[GoogleCodeExporter]

Previous fix has a significant impact on speeds of all 2-pass encoding and has 
been reverted, proposing an alternative fix here:
https://gerrit.chromium.org/gerrit/#/c/70388/2

Original comment by ya...@google.com on 3 Jun 2014 at 10:04

[GoogleCodeExporter]

Tested head, the issue is fixed as of current head

Original comment by ya...@google.com on 15 Jul 2014 at 7:02

[GoogleCodeExporter]

Original comment by ya...@google.com on 15 Jul 2014 at 7:02

• Changed state: Fixed