search

dinhnhobao / pe

0 stars 0 forks source link

vomit with /portion > 1 should not be allowed #12

Open dinhnhobao opened 4 years ago

dinhnhobao commented 4 years ago

However, I think the system still understands and choose portion as 1 (all) instead

nus-pe-bot commented 4 years ago

Team's Response

Hi there.

This is not a bug. This is actually a user-centric feature that rounds down to the maximum portions to delete, so the user doesn't have to think too much on how many to delete.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: If the vomit portion is > 1, you should notify the user instead that it's invalid. Putting the vomid portion > 1 means that the users did not understand what your vomit command does, in that case, it would create much more confusion for the users if you keep executing the command with a full vomit (portion = 1). You should notify them that the portion should not exceed 1.