search

dinhnhobao / pe

0 stars 0 forks source link

Unclear activity diagram #24

Open dinhnhobao opened 4 years ago

dinhnhobao commented 4 years ago

"valid format" then we have "exist" and "do not exist" image.png

nus-pe-bot commented 4 years ago

Team's Response

Hi there.

You did not mention which figure this is from. Our guess is from here:

image.png

As you can see, if the argument (which is the DailyFoodLog) exists, then it will follow the path on the left. Otherwise, it will follow the one on the right. Therefore, placing 'exist' in the condition would refer to the DailyFoodLog, which is also where the word originally appears.

Cheers!

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I would reduce it to a severity.VeryLow DocumentationBug. It's not clear that you meant the DailyFoodLog exists. The branching condition should be DailyFoodLog exists and else instead. Also, it's confusing that you only have one argument DailyFoodLog, but there's a line that say "Ensure arguments have valid format", so I'm not sure how many arguments there are in the Command, and as a result which argument you are referring to in the branching condition.

TL;DR I believe you should put DailyFoodLog exists and else as the branching conditions instead of just exist which is ambigious.