search

dinhnhobao / pe

0 stars 0 forks source link

Invalid help commands #9

Open dinhnhobao opened 4 years ago

dinhnhobao commented 4 years ago

help me is an invalid command which should recognise that I am using the help command. However, it says "no commands contain this keyword" which is incorrect"

image.png

nus-pe-bot commented 4 years ago

Team's Response

The "help" command follows the format of the other commands, namely the command's name, then in this case a substring. image.png

As shown here, if "help nom" is keyed in, the command first identifies the command as being of type "help", then searches through all commands for any that contain the substring "nom" and displays that. image.png

Thus, "help me" will only check commands if they contain the substring "me", which none do. The command should not include "help" in the substring.

Severity (if any): low because this unlikely affects normal operation (if any)/brings minor inconvenience (if any). Note that this is explained despite us rejecting it, as the Github forum requires us to explain any changes to severity.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]