Closed yorkie closed 10 years ago
That's good progress! Could you keep only in this pull request everything related to use of nan and have an other pull request for other stuff? Thanks.
Yup, I will make this change later.
Hi, @dinhviethoa, I have reverted a commit, now this PR just is do the compatible stuffs.
I reviewed it entirely. Just make the macro back to a function and it's good to go.
Okay, I define a NAN_METHOD2
to follow your requirement
so sorry about this late commit :(
ping @dinhviethoa
Please, change the name of the define.
Ok, I have renamed that function to NAN_PRIVATE_FUNCTION.
Merging now!
Cheers, and then we would add another part of this module before bumping node-mailcore
. :)
hi, @dinhviethoa
I use nan to rebuild this module, and it works fine on 0.10.x and 0.11.x. Plus, I added the new api from #12, that would only expose etpan to
node-mailcore
and added some tests for them, then I think a.travis.yml
is necessary for now?