compatible: let this module works on 0.10.x and 0.11.x

dinhvh / libetpan.node

NodeJS binding for libetpan.

3 stars 1 forks source link

compatible: let this module works on 0.10.x and 0.11.x #13

Closed yorkie closed 10 years ago

yorkie commented 10 years ago

hi, @dinhviethoa

I use nan to rebuild this module, and it works fine on 0.10.x and 0.11.x. Plus, I added the new api from #12, that would only expose etpan to node-mailcore and added some tests for them, then I think a .travis.yml is necessary for now?

dinhvh commented 10 years ago

That's good progress! Could you keep only in this pull request everything related to use of nan and have an other pull request for other stuff? Thanks.

yorkie commented 10 years ago

Yup, I will make this change later.

yorkie commented 10 years ago

Hi, @dinhviethoa, I have reverted a commit, now this PR just is do the compatible stuffs.

dinhvh commented 10 years ago

I reviewed it entirely. Just make the macro back to a function and it's good to go.

yorkie commented 10 years ago

Okay, I define a NAN_METHOD2 to follow your requirement so sorry about this late commit :(

yorkie commented 10 years ago

ping @dinhviethoa

dinhvh commented 10 years ago

Please, change the name of the define.

yorkie commented 10 years ago

Ok, I have renamed that function to NAN_PRIVATE_FUNCTION.

dinhvh commented 10 years ago

Merging now!

yorkie commented 10 years ago

Cheers, and then we would add another part of this module before bumping node-mailcore. :)