search

dinhvh / libetpan.node

NodeJS binding for libetpan.
3 stars 1 forks source link

fix a bug in `login` command. #7

Closed yorkie closed 10 years ago

yorkie commented 10 years ago

When I received a IMAP message like below:

C: A1 LOGIN "yorkiefixer@gmail.com" "invalid-password"
S: A1 NO ��¼ʧ��[������ʺ�]

So I fixed it.

dinhvh commented 10 years ago

Can you use != instead of >
Thanks.

Hoa V. Dinh

On Tuesday, December 17, 2013 at 1:15 AM, Yorkie wrote:

When I received a IMAP message like below: C: A1 LOGIN "yorkiefixer@gmail.com" "invalid-password" S: A1 NO ��¼ʧ��[������ʺ�]
So I fixed it. You can merge this Pull Request by running git pull https://github.com/yorkie/libetpan.node master Or view, comment on, or merge it at: https://github.com/dinhviethoa/libetpan.node/pull/7 Commit Summary fix a bug in login command.

File Changes M binding.gyp (https://github.com/dinhviethoa/libetpan.node/pull/7/files#diff-0) (6)
M src/libetpanjs.cc (https://github.com/dinhviethoa/libetpan.node/pull/7/files#diff-1) (4)

Patch Links: https://github.com/dinhviethoa/libetpan.node/pull/7.patch https://github.com/dinhviethoa/libetpan.node/pull/7.diff

yorkie commented 10 years ago

Yes, I have updated my code and squashed them.