search

dinhvh / libetpan

Mail Framework for C Language
www.etpan.org
Other
611 stars 284 forks source link

Please remove legacy VoIP feature #444

Open k-gruenberg opened 7 months ago

k-gruenberg commented 7 months ago

In these two lines you are referencing kCFStreamNetworkServiceTypeVoIP. According to this thread however, it is referring to a legacy VoIP feature that has finally been removed in iOS 17. The result is that no matter whether I use the MailCore or the Postal library, I get the exact same crash when trying to connect to an IMAP server. The fact that you surrounded the whole thing with #if TARGET_OS_IPHONE && !TARGET_IPHONE_SIMULATOR made this especially hard to debug as the error does not occur when running my app in the simulator. Please remove the references to this feature as it was non-functional for a long time now anyways. Thanks!

barracuda156 commented 6 months ago

@k-gruenberg It is only used for iOS, not macOS, is it?

k-gruenberg commented 6 months ago

@barracuda156 I think that's pretty much what #if TARGET_OS_IPHONE says, yeah. Personally, I'm developing an iOS-only app (for now) and that's where I wanted to use it. If you're interested in my current solution to the problem: use a working Rust library instead and use FFI to call the Rust code from Swift. Pretty pathetic for a language like Swift when there aren't really any working email libraries...

barracuda156 commented 6 months ago

that's pretty much what #if TARGET_OS_IPHONE says

@k-gruenberg Yeah, that’s what I also thought, just wanted to make sure. My concern is to avoid breaking the build for older macOS versions, but anything iOS-only is inconsequential for that.