dini-ag-kim / hcrt

Hochschulcampus Ressourcentypen (Werteliste für Typen von Lernressourcen) https://w3id.org/kim/hcrt/scheme
1 stars 5 forks source link

Add English labels #2

Closed acka47 closed 3 years ago

acka47 commented 3 years ago

As discussed in yesterday's OERSI meeting (see to dos).

axel-klinger commented 3 years ago

Hi, thanks for this first version. Just some things, that I would suggest to fix:

Additional material suggestion:

acka47 commented 3 years ago

Thanks @axel-klinger for these good suggestions for improvement. Re. captial letters, I followed the example of LRMI vocabs but I am fine with changing it and added a corresponding commit in which I also changed "educational game" to "Game" and "presentation slides" to "presentation".

Re. updating German labels: I support all those proposals but don't want to just implement them without at least consulting @mic-men: Are those changes ok for you too, Michael? If yes, I suggest to proceed as follows: Merge this PR, then open another one with the German label changes and notify on the OER-Metadatengruppe list about the pending changes. If nobody objects, we can merge it. (This would also be a test for implementing bigger changes like @axel-klinger's proposal for adding some more types.)

acka47 commented 3 years ago

BTW, the addEnglishLabels branch can also be viewed on SkoHub, see https://skohub.io/dini-ag-kim/hcrt/heads/addEnglishLabels/w3id.org/kim/hcrt/scheme.html. However, as we do not support internationalization in the HTML representation yet (see https://github.com/hbz/skohub-vocabs/issues/79), this does not differ much from the main version and thus in this case is not suited for review purposes.

mic-men commented 3 years ago

I agree with the proposals by @axel-klinger for changing German labels - only for "Bild" instead of "Abbildung" I don't see the point but it's not really important to me. For additional materials let's postpone that a bit. I think it needs more discussion.